Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RFC 2119's keywords (MUST, MAY, ...) #9

Merged
merged 1 commit into from
Dec 17, 2015
Merged

Use RFC 2119's keywords (MUST, MAY, ...) #9

merged 1 commit into from
Dec 17, 2015
+12 −12

Conversation

wking
Copy link
Owner

@wking wking commented Dec 9, 2015

The spec landed an RFC 2119 approach in opencontainers/runtime-spec#260.
There is already some discussion on a previous version of this commit
here, as well as some related RFC 2119 work in #8.

mikebrow
mikebrow reviewed Dec 11, 2015
View reviewed changes
runtime.md
A conformant runtime should provide an executable (called `funC` in the following examples).
The template for supported commands is:
A conformant runtime MUST provide an executable (called `funC` in the following examples).
That executable MUST support commands with the following template:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, looks good.

@mikebrow
Copy link
Collaborator

@wking just need one minor fix see above.

@wking
Copy link
Owner Author

wking commented Dec 11, 2015

On Fri, Dec 11, 2015 at 08:11:54AM -0800, Mike Brown wrote:

@wking just need one minor fix see above.

I just pushed 52ca435 → 6f5ae34, rebasing around the just-landed #8
and fixing the “to its stdout” typo 1.

@wking
Copy link
Owner Author

wking commented Dec 12, 2015

On Fri, Dec 11, 2015 at 08:39:43AM -0800, W. Trevor King wrote:

I just pushed 52ca435 → 6f5ae34, rebasing around the just-landed #8
and fixing the “to its stdout” typo [1].

And I just pushed 6f5ae34 → be67069, resolving a conflict with the
just-landed #11 (since the typo fix in the 6f5ae34 commit maybe reset
the two-workday clock on this one).

@wking
Use RFC 2119's keywords (MUST, MAY, ...)
e41ffc1 
This approach has landed in opencontainers/specs [1,2].  You can find
the RFC here [3].

[1]: opencontainers/runtime-spec#256
[2]: opencontainers/runtime-spec#260
[3]: http://tools.ietf.org/html/rfc2119

Signed-off-by: W. Trevor King <wking@tremily.us>
Reviewed-by: Mike Brown <brownwm@us.ibm.com>
@wking wking merged commit e41ffc1 into master Dec 17, 2015
@wking
Copy link
Owner Author

wking commented Dec 17, 2015

On Fri, Dec 11, 2015 at 05:04:58PM -0800, W. Trevor King wrote:

And I just pushed 6f5ae34 → be67069, resolving a conflict with the
just-landed #11 (since the typo fix in the 6f5ae34 commit maybe
reset the two-workday clock on this one).

Merged with a @mikebrow Signed-off-by, since I fixed the typo he
pointed out 1, and all the rest of his comments were LGTMs ;).

@wking wking deleted the rfc-2119 branch June 1, 2016 04:34
wking added a commit that referenced this pull request Jun 22, 2016
@wking
runtime: RFC 2119 SHOULDs in the "Character encodings" section
391c7b5 
These slipped through e41ffc1 (Use RFC 2119's keywords (MUST, MAY,
...), 2015-12-02, #9).

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking wking mentioned this pull request Jun 22, 2016
Merged
wking added a commit that referenced this pull request Jul 5, 2016
@wking
runtime: RFC 2119 SHOULDs in the "Character encodings" section
b7429c8 
These slipped through e41ffc1 (Use RFC 2119's keywords (MUST, MAY,
...), 2015-12-02, #9).

Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wking @mikebrow