-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RFC 2119's keywords (MUST, MAY, ...) #9
Conversation
A conformant runtime should provide an executable (called `funC` in the following examples). | ||
The template for supported commands is: | ||
A conformant runtime MUST provide an executable (called `funC` in the following examples). | ||
That executable MUST support commands with the following template: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed, looks good.
@wking just need one minor fix see above. |
On Fri, Dec 11, 2015 at 08:39:43AM -0800, W. Trevor King wrote:
And I just pushed 6f5ae34 → be67069, resolving a conflict with the |
This approach has landed in opencontainers/specs [1,2]. You can find the RFC here [3]. [1]: opencontainers/runtime-spec#256 [2]: opencontainers/runtime-spec#260 [3]: http://tools.ietf.org/html/rfc2119 Signed-off-by: W. Trevor King <wking@tremily.us> Reviewed-by: Mike Brown <brownwm@us.ibm.com>
On Fri, Dec 11, 2015 at 05:04:58PM -0800, W. Trevor King wrote:
Merged with a @mikebrow Signed-off-by, since I fixed the typo he |
The spec landed an RFC 2119 approach in opencontainers/runtime-spec#260.
There is already some discussion on a previous version of this commit
here, as well as some related RFC 2119 work in #8.